Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nextcloud backup role #268

Merged
merged 45 commits into from
May 19, 2023
Merged

Add nextcloud backup role #268

merged 45 commits into from
May 19, 2023

Conversation

wiktor2200
Copy link
Collaborator

Hi @aalaesar @staticdev!
As mentioned in #260 I'm adding role to this repo as copy of @aalaesar role with whole commit hisotry.
It's adding backup role as discussed in #228.

aalaesar and others added 30 commits April 15, 2022 00:17
@aalaesar
Initial commit
835f730
@aalaesar
first version of server files backup
0546874
@aalaesar
exit maintenance node task
da1f2a7
@aalaesar
move task to another file
22cf0ac
@aalaesar
add app_data & user data backup
2707dfd
@aalaesar
add db dump automation
eff3887
@aalaesar
finishing backup
e1dc5ad
@aalaesar
use camel_case
268f967
@aalaesar
ansible-lint fixes
6c749f8
@aalaesar
adjusting for documentation
a6aff33
@aalaesar
fix ansible_lint issue
4e635cb 
renamed the role to use _
@aalaesar
add examples in readme
148f3da
@aalaesar
adjusting metadata for ansible galaxy
b0b8c90
@aalaesar
fix missing jinja bracets
3fe51c4
@aalaesar
fix spaces outside of jinja brackets
606bf98
@aalaesar
add archive format
b1cc779
@wiktor2200
yamllint fixes
ab50548
@wiktor2200
Add github actions - yamllint, ansible-lint and pre-commit
830742f
@aalaesar
Merge pull request nextcloud#7 from wiktor2200/improve-fmt-and-yamllint
2d3ebe5 
Improve fmt and yamllint
@aalaesar
completed metadatas and fix ansible-lint errors
195466c
@aalaesar
fix tasks name casing
acfa421
@aalaesar
fix key ordering
90d3e19
@aalaesar
Merge pull request nextcloud#8 from aalaesar/fix_ansible_lint
116c77f 
Fix ansible lint errors and warnings
@wiktor2200 @aalaesar
change become parameters to variables
815fed1
@aalaesar
use ad-hoc var to adjust user for occ commands
eda3865 
automatically select proper method and flags depending on 1 command result
@wiktor2200
Fix chmod mode bug with directories
cd95984
@wiktor2200
fmt
cd19243
@wiktor2200
Introduce backup featch feature
fbcef93
@aalaesar
Merge pull request nextcloud#5 from wiktor2200/fix-chmod-mode-bug
9a12f1d 
Fix chmod mode bug
@wiktor2200
Merge branch 'master' of github.com:aalaesar/backup_nextcloud into in…
f75e98c 
…troduce-backup-fetch-feature
aalaesar and others added 11 commits February 2, 2023 13:26
@aalaesar
fix jinja not passing the test result to filter
70bd32c
@aalaesar
change dpkg command.
d60930b 
listing is not enough to get proper rc
@aalaesar
Merge pull request nextcloud#9 from aalaesar/victor2200/fix-become_me…
787a2d5 
…thod-parameter

set  become method depending of host config
@wiktor2200
Merge branch 'master' into introduce-backup-fetch-feature
9f3e229
@wiktor2200
remove duplicated condition
a9ab7f0
@aalaesar
Merge pull request nextcloud#6 from wiktor2200/introduce-backup-fetch…
07b13a2 
…-feature

Introduce backup fetch feature
@wiktor2200
Add switch for dowloading Nextcloud-server archive
f1ce67d
@wiktor2200
change default value for archive download
ec201dc
@aalaesar
Merge pull request nextcloud#10 from wiktor2200/add-switch-for-nextcl…
922a569 
…oud-server-archive-download

Add switch for downloading Nextcloud-server archive
@wiktor2200
Add 'roles/backup_nextcloud/' from commit '922a569d339f05716a69cb27b3…
7a71495 
…8bcf9089f2ea25'

git-subtree-dir: roles/backup_nextcloud
git-subtree-mainline: 0783f15
git-subtree-split: 922a569
@wiktor2200
role cleanup
d424c70
@wiktor2200 wiktor2200 added enhancement New feature or request Feature labels Apr 29, 2023
@wiktor2200 wiktor2200 mentioned this pull request Apr 29, 2023
Closed
@wiktor2200
add missing requirement
041c3cb 
Signed-off-by: wiktor2200 <wiktor2200@users.noreply.github.com>
@wiktor2200
Copy link
Collaborator Author

FYI: @aalaesar @staticdev
I also updated license to be the same as for whole collection GPL3 -> BSD.

@staticdev
Copy link
Collaborator

@wiktor2200 I do not have permissions to push to your fork.. should I fork your fork and create a PR there XD?

@wiktor2200
Copy link
Collaborator Author

Hi! @staticdev @aalaesar I've invited you as collaborators to my fork, so now you would be able to commit to my branch and this PR would be updated automatically. :)

@staticdev
Port changes from nextcloud#260
c04643c 
Signed-off-by: staticdev <staticdev-support@proton.me>
@staticdev staticdev changed the title WIP: Add nextcloud backup role Add nextcloud backup role May 7, 2023
staticdev
staticdev approved these changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aalaesar @wiktor2200 From my side, I think we should merge. Now we have the history, I was able to do some smoke test and also informed in the main readme of the collection that this role is in beta. Also the code is not entirely new, and we can handle next steps in enhancement and bugfix issues. What do you think? LGTM?

@wiktor2200
Copy link
Collaborator Author

Hi @staticdev! Sorry for late response, been busy recently. I think we are ready to merge, old code is imported, new changes are added and we've got commit history.
And as it's marked as beta everyone probably take that into consideration before use, nevertheless it works.
As next steps we can create some molecule tests to create whole deploy -> backup -> restore process.
@aalaesar, do you agree? :)

@staticdev staticdev merged commit 9d1d9ca into nextcloud:main May 19, 2023
@staticdev staticdev deleted the add-nextcloud-backup-role branch May 19, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticdev staticdev staticdev approved these changes

@aalaesar aalaesar Awaiting requested review from aalaesar

Assignees
No one assigned
Labels
enhancement New feature or request Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiktor2200 @staticdev @aalaesar